Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[13_2_X] Use ZDC digis in uGT DQM #43113

Merged

Conversation

dinyar
Copy link
Contributor

@dinyar dinyar commented Oct 25, 2023

PR description:

Add unpacked ZDC digis to uGT DQM. This was overlooked when the ZDC unpacker was added to CMSSW.

Backport of #43043

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 25, 2023

A new Pull Request was created by @dinyar (Dinyar Rabady) for CMSSW_13_2_X.

It involves the following packages:

  • DQM/L1TMonitor (dqm)

@syuvivida, @rvenditti, @nothingface0, @cmsbuild, @tjavaid, @antoniovagnerini can you please review it and eventually sign? Thanks.
@missirol this is something you requested to watch as well.
@rappoccio, @sextonkennedy, @antoniovilela you are the release manager for this.

cms-bot commands are listed here

@tjavaid
Copy link

tjavaid commented Oct 26, 2023

please test

@tjavaid
Copy link

tjavaid commented Oct 26, 2023

backport of #43043

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-4adcba/35446/summary.html
COMMIT: f1c31a2
CMSSW: CMSSW_13_2_X_2023-10-26-1100/el8_amd64_gcc11
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/43113/35446/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • You potentially removed 6 lines from the logs
  • Reco comparison results: 10 differences found in the comparisons
  • DQMHistoTests: Total files compared: 48
  • DQMHistoTests: Total histograms compared: 3198785
  • DQMHistoTests: Total failures: 6
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3198757
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 47 files compared)
  • Checked 207 log files, 159 edm output root files, 48 DQM output files
  • TriggerResults: no differences found

@syuvivida
Copy link
Contributor

@dinyar very sorry for our late test, only got a chance to test this PR at playback with DQM streamers of run 375631. It's not clear to me if you could see any difference in DQMGUI plots. DQM clients all ran without problems. Could you take a look of the playback DQMGUI here in case any difference could be seen in L1T workspace?
https://cmsweb.cern.ch/dqm/online-playback
Thanks!!

@tjavaid
Copy link

tjavaid commented Nov 3, 2023

@dinyar very sorry for our late test, only got a chance to test this PR at playback with DQM streamers of run 375631. It's not clear to me if you could see any difference in DQMGUI plots. DQM clients all ran without problems. Could you take a look of the playback DQMGUI here in case any difference could be seen in L1T workspace? https://cmsweb.cern.ch/dqm/online-playback Thanks!!

Hi @dinyar , are you okay with the DQM GUI plots? The rest of the checks are okay to sign this PR.

@tjavaid
Copy link

tjavaid commented Nov 4, 2023

+1

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 4, 2023

This pull request is fully signed and it will be integrated in one of the next CMSSW_13_2_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_13_3_X is complete. This pull request will now be reviewed by the release team before it's merged. @rappoccio, @sextonkennedy, @antoniovilela (and backports should be raised in the release meeting by the corresponding L2)

@rappoccio
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit 41b3549 into cms-sw:CMSSW_13_2_X Nov 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants